Skip to content

chore: fix JavaScript lint errors (issue #7782) #7789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2025

Conversation

NEEKUorAAYUSH
Copy link
Contributor

Resolves #7782.

Description

This pull request fixes a JavaScript lint error in resolve.sync.js.
Specifically, it replaces the disallowed new Array(len) constructor with Array.from({ length: len }) to comply with the project's linting rules.

Related Issues

This pull request:

Questions

No questions for reviewers.

Other

No other information.

Checklist


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Tools Issue or pull request related to project tooling. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Aug 2, 2025
@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Aug 2, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after cleaning up.

@NEEKUorAAYUSH Please see my changes. Notice that they actually do what is requested in error message displayed in the upstream issue.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Aug 3, 2025
@kgryte kgryte merged commit eb5552e into stdlib-js:develop Aug 3, 2025
8 checks passed
@NEEKUorAAYUSH
Copy link
Contributor Author

@kgryte . Thank you for the clarification and the fix! I understand the issue now — initializing cache with Array.from caused issues, and using push was the proper approach. I’ll be more careful with array initialization and indexing in the future. Appreciate your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Tools Issue or pull request related to project tooling.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors
3 participants